issue 646 - fix output error in Index_2, plus two minor output tweaks #647
Conversation
|
Ian, |
There was a problem hiding this comment.
The changes look good to me. Thanks for fixing the issue so quickly.
The "Q" to "Qbase" change wasn't the issue for r4ss, rather the logic for parsing the INDEX_2 table wasn't adaptable to the additional comment line (unlike most other tables). I think I fixed the r4ss issue on the second try and just restarted the failed github action for the second time. If it passes the check (should be done in about 15 minutes) I think it's fine to merge.
|
The @e-perl-NOAA do you know why @Rick-Methot-NOAA, do you think this bug needs a bug-fix release? It seems like users interested in Q_type 3 = power (+1 parm) which is causing the error fixed by this PR. could temporarily use type 6=offset & power (+2p) with the offset parameter fixed at 0 and get all the functionality of type 3. If we announced that solution on the forum we could potentially avoid a bug fix release and just wait until other features are ready for a bigger release. |
|
I thought the same Ian. Let's do a bug fix release for this one. |
|
I have no idea why it was skipped, but I'm running it here |
|
Let's do both a big fix and a message in the Forum. The Forum message can serve to advertise the availability of the offset approach. |
|
Sounds good. |
|
Sounds good! |
Rick-Methot-NOAA
deleted the
646-bug-model-crash-during-output-stage-when-using-qpower
branch
e-perl-NOAA
added
change log
Concisely describe what has been changed/addressed in the pull request.
fixes output error in Index_2 that was introduced with Qtype 6.
What tests have been done?
Where are the relevant files?
[x] Test files are in the issue.
What tests/review still need to be done?
None
Is there an input change for users to Stock Synthesis?
[x] No, there was no input change.
Additional information (optional).